Adds one more test to challenge 3.js of js2 to catch Nx0 array errors #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthonykhoa
reviewed
Dec 23, 2021
| @@ -19,4 +19,8 @@ describe('Generate 2D array', () => { | |||
| const result = solution(1, 5) | |||
| expect(result).toEqual([[0, 0, 0, 0, 0]]) | |||
| }) | |||
| it('should generate 3x0 array', () => { | |||
| const result = solution(3, 0) | |||
| expect(result).toEqual([0],[0],[0]) | |||
There was a problem hiding this comment.
You are missing the array that the other arrays are contained in.
toEqual([0],[0],[0]) should be toEqual([[0],[0],[0]]).
Another issue to fix is the actual expected output.
The problem description says Every element in the array is an array that is equal to the length of the second input number. All values in the array is 0.
If the length of second input number is 0, then shouldn't the array length correspondingly be 0? Looks like [[0],[0],[0]] would be wrong because each array in that array of arrays has a length of one.
So solution(3, 0) should output [[], [], []]
anthonykhoa
requested changes
Dec 23, 2021
|
Closing - old |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Closes issue #376.
Currently this solution to challenge 3 passes all the tests and gets accepted despite the range error.
Solution
Additional test added to test the Nx0 array:
